Skip to content

Conversation

@StaberindeZA
Copy link
Contributor

Because

  • The subscription reminders script needs to support daily subscription prices.

This pull request

  • Optionally adds support for daily subscription prices, so that it can be toggled on and off where required.
  • Updates script to allow unsupported params. This was done to allow updates to the CRON jobs with new parameters, before those parameters have shipped.

Issue that this pull request solves

Closes: PAY-2294

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

Screenshots (Optional)

Please attach the screenshots of the changes made in case of change in user interface.

Other information (Optional)

Any other information that is important to this pull request.

@StaberindeZA StaberindeZA requested a review from a team as a code owner January 7, 2026 22:11
@StaberindeZA StaberindeZA force-pushed the pay-3366-stay-subscribed-email branch from ed78672 to 4ae268e Compare January 7, 2026 22:13
@StaberindeZA StaberindeZA requested a review from a team as a code owner January 7, 2026 22:13
# $productName (String) - The name of the subscribed product, e.g. Mozilla VPN
# $serviceLastActiveDateOnly (String) - The date of last active service, e.g. 01/20/2016
subscriptionEndingReminder-content-line1 = Your access to { $productName } will end on <strong>{ $serviceLastActiveDateOnly }</strong>.
subscriptionEndingReminder-content-line2 = If you’d like to continue using { $productName }, you can reactive your subscription in <a data-l10n-name="subscriptionEndingReminder-account-settings">Account Settings</a> before <strong>{ $serviceLastActiveDateOnly }</strong>. If you need assistance, <a data-l10n-name="subscriptionEndingReminder-contact-support">contact our Support Team</a>.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
subscriptionEndingReminder-content-line2 = If you’d like to continue using { $productName }, you can reactive your subscription in <a data-l10n-name="subscriptionEndingReminder-account-settings">Account Settings</a> before <strong>{ $serviceLastActiveDateOnly }</strong>. If you need assistance, <a data-l10n-name="subscriptionEndingReminder-contact-support">contact our Support Team</a>.
subscriptionEndingReminder-content-line2 = If you’d like to continue using { $productName }, you can reactivate your subscription in <a data-l10n-name="subscriptionEndingReminder-account-settings">Account Settings</a> before <strong>{ $serviceLastActiveDateOnly }</strong>. If you need assistance, <a data-l10n-name="subscriptionEndingReminder-contact-support">contact our Support Team</a>.

Potential typo?

subscriptionEndingReminder-content-line1 = Your access to { $productName } will end on <strong>{ $serviceLastActiveDateOnly }</strong>.
subscriptionEndingReminder-content-line2 = If you’d like to continue using { $productName }, you can reactive your subscription in <a data-l10n-name="subscriptionEndingReminder-account-settings">Account Settings</a> before <strong>{ $serviceLastActiveDateOnly }</strong>. If you need assistance, <a data-l10n-name="subscriptionEndingReminder-contact-support">contact our Support Team</a>.
subscriptionEndingReminder-content-line1-plaintext = Your access to { $productName } will end on { $serviceLastActiveDateOnly }.
subscriptionEndingReminder-content-line2-plaintext = If you’d like to continue using { $productName }, you can reactive your subscription in Account Settings before { $serviceLastActiveDateOnly }. If you need assistance, contact our Support Team.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
subscriptionEndingReminder-content-line2-plaintext = If you’d like to continue using { $productName }, you can reactive your subscription in Account Settings before { $serviceLastActiveDateOnly }. If you need assistance, contact our Support Team.
subscriptionEndingReminder-content-line2-plaintext = If you’d like to continue using { $productName }, you can reactivate your subscription in Account Settings before { $serviceLastActiveDateOnly }. If you need assistance, contact our Support Team.

@StaberindeZA StaberindeZA force-pushed the pay-3366-stay-subscribed-email branch 2 times, most recently from cc8c112 to c82a0d4 Compare January 8, 2026 21:31
@StaberindeZA StaberindeZA force-pushed the pay-2294-cron-updates-reminders branch from c1ec5af to 1e4c769 Compare January 8, 2026 21:59
@StaberindeZA StaberindeZA force-pushed the pay-3366-stay-subscribed-email branch from c82a0d4 to 9c85f61 Compare January 8, 2026 22:02
@StaberindeZA StaberindeZA force-pushed the pay-2294-cron-updates-reminders branch from 1e4c769 to aaa85d6 Compare January 8, 2026 22:07
Copy link
Contributor

@bcolsson bcolsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as it appears the string changes were moved to a different PR.

@StaberindeZA StaberindeZA force-pushed the pay-3366-stay-subscribed-email branch 2 times, most recently from af5bea9 to 708eb16 Compare January 9, 2026 15:42
Base automatically changed from pay-3366-stay-subscribed-email to main January 9, 2026 16:37
@StaberindeZA StaberindeZA force-pushed the pay-2294-cron-updates-reminders branch from aaa85d6 to b57df69 Compare January 9, 2026 17:12
Because:

- The subscription reminders script needs to support daily
  subscription prices.

This commit:

- Optionally adds support for daily subscription prices, so
  that it can be toggled on and off where required.
- Updates script to allow unsupported params. This was done
  to allow updates to the CRON jobs with new parameters,
  before those parameters have shipped.

Closes #PAY-2294
@StaberindeZA StaberindeZA force-pushed the pay-2294-cron-updates-reminders branch from b57df69 to 8e4d2a2 Compare January 9, 2026 17:54
@StaberindeZA StaberindeZA merged commit fc6721f into main Jan 9, 2026
22 checks passed
@StaberindeZA StaberindeZA deleted the pay-2294-cron-updates-reminders branch January 9, 2026 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants