Skip to content

feat(payments): Update Cancel and Stay subscribed pages #19861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xlisachan merged 1 commit into from
Jan 12, 2026
Merged

feat(payments): Update Cancel and Stay subscribed pages #19861

xlisachan merged 1 commit into from
Jan 12, 2026

Conversation

@xlisachan
Copy link
Contributor

@xlisachan xlisachan commented Jan 8, 2026 •
edited
Loading

This pull request

  • Updates Cancel and Stay subscribed pages to check if customer is eligible for existing churn coupon, if so, navigate to respective pages.

Issue that this pull request solves

Closes: PAY-3455

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

@xlisachan xlisachan force-pushed the update_pages branch 3 times, most recently from af466c9 to 0118b99 Compare January 9, 2026 14:50
@xlisachan xlisachan changed the base branch from main to PAY-3364 January 9, 2026 18:40
@xlisachan xlisachan force-pushed the update_pages branch 2 times, most recently from 33893e3 to 9a400c1 Compare January 9, 2026 18:47
@xlisachan xlisachan changed the base branch from PAY-3364 to main January 12, 2026 14:23
@xlisachan xlisachan changed the base branch from main to PAY-3364 January 12, 2026 14:24
@xlisachan xlisachan force-pushed the PAY-3364 branch 2 times, most recently from 1e67ccc to ed681de Compare January 12, 2026 20:03
Base automatically changed from PAY-3364 to main January 12, 2026 20:27
@xlisachan xlisachan force-pushed the update_pages branch 2 times, most recently from 0abb011 to bf6915d Compare January 12, 2026 20:33
julianpoy
julianpoy reviewed Jan 12, 2026
View reviewed changes
apps/payments/next/app/[locale]/subscriptions/[subscriptionId]/cancel/page.tsx
Comment on lines +43 to +51
if (pageContent.isEligibleForChurnCancel === true) {
redirect(
`/${locale}/subscriptions/${subscriptionId}/loyalty-discount/cancel`
);
}

if (pageContent.isEligibleForCancelInterstitialOffer === true) {
redirect(`/${locale}/subscriptions/${subscriptionId}/offer`);
}
Copy link
Member

@julianpoy julianpoy Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(for my info) since we don't return in either of these statements it looks like they could both get called, which redirect takes precedence?

Copy link
Contributor Author

@xlisachan xlisachan Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first redirect takes precedence.

@xlisachan xlisachan marked this pull request as ready for review January 12, 2026 21:54
@xlisachan xlisachan requested a review from a team as a code owner January 12, 2026 21:54
@xlisachan xlisachan merged commit a20b6fe into main Jan 12, 2026
22 checks passed
@xlisachan xlisachan deleted the update_pages branch January 12, 2026 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@julianpoy julianpoy julianpoy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xlisachan @julianpoy