Skip to content

Conversation

@toufali
Copy link
Member

@toufali toufali commented Jan 8, 2026

Because

  • the "new device" email is not sent after successful email confirmation

This pull request

  • adds the functionality

Issue that this pull request solves

Closes: FXA-12802

Other information (Optional)

See the original comment from @vpomerleau, who discovered the issue. From that comment, steps to repro:

  1. Set env vars:
    SERVICES_WITH_EMAIL_VERIFICATION=dcdb5ae7add825d2
    SIGNIN_CONFIRMATION_SKIP_FOR_NEW_ACCOUNTS=false
  2. Create a new account
  3. Open new profile with the dev launcher (yarn firefox)
  4. Go to 123Done (localhost:8080)
  5. Sign in with email
  6. Enter password

@toufali toufali requested a review from a team as a code owner January 8, 2026 17:04
Copy link
Contributor

@vbudhram vbudhram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@toufali This sends email 👍🏽, might be useful to update the corresponding test to assert mailer called in this state.

@toufali toufali force-pushed the fix-missing-new-device-email branch from f23ba66 to d941b2e Compare January 13, 2026 16:03
@toufali
Copy link
Member Author

toufali commented Jan 13, 2026

@toufali This sends email 👍🏽, might be useful to update the corresponding test to assert mailer called in this state.

Thanks @vbudhram, test updated 👍

@toufali toufali merged commit af25995 into main Jan 13, 2026
22 checks passed
@toufali toufali deleted the fix-missing-new-device-email branch January 13, 2026 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants