task(auth): Separate extraction of emails.ftl and auth.ftl strings#20008
Open
task(auth): Separate extraction of emails.ftl and auth.ftl strings#20008
Conversation
dschom
force-pushed
the
fix-l10n-merge
branch
2 times, most recently
from
a6fb8fc to
9a19836
Compare
Because: - We don't want to duplicate translation strings. - We want to start move over to using ftl files in libs/accounts/email-render This Commit: - Sends l10n strings in the email lib that are currently being used to emails.ftl - Sends l10n strings in the email lib that are currently being used to emails.ftl - Removes tests that are no applicable from auth-server
dschom
force-pushed
the
fix-l10n-merge
branch
from
9a19836 to
ad805ae
Compare
dschom
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
.ftlfiles inlibs/accounts/email-renderThis pull request
emails.ftlemails.ftlIssue that this pull request solves
Closes: FXA-12947 (partially*)
Checklist
Put an
xin the boxes that applyScreenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
The other piece of this puzzle is over here: mozilla/fxa-content-server-l10n#1015