feat(passkeys): Add passkey manager functions#20135
Open
vpomerleau wants to merge 1 commit intomainfrom
Open
Conversation
64adc6c to
e4f2a6c
Compare
dschom
reviewed
Mar 4, 2026
dschom
reviewed
Mar 4, 2026
dschom
reviewed
Mar 4, 2026
dschom
reviewed
Mar 4, 2026
dschom
reviewed
Mar 4, 2026
dschom
reviewed
Mar 4, 2026
dschom
reviewed
Mar 4, 2026
dschom
reviewed
Mar 4, 2026
dschom
reviewed
Mar 4, 2026
dschom
reviewed
Mar 4, 2026
dschom
reviewed
Mar 4, 2026
dschom
approved these changes
Mar 4, 2026
Contributor
dschom
left a comment
There was a problem hiding this comment.
R+WC. Looks good overall. I do have a couple concerns around the replay attack implementation and what I think might end up being a race condition. Feel free to turn those into fast follows, if you want to unblock the jira ticket.
Because: - The passkey routes needs to enforce business rules before touching the database This commit: - Implements PasskeyManager with the full passkey lifecycle: register, post-auth update, list, rename, delete, and bulk delete - Guards maxPasskeysPerUser config with @min(1) to prevent accidentally disabling registration - Adds unit and integration tests for the manager Closes #FXA-13064
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: FXA-13064
Checklist
Put an
xin the boxes that applyScreenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
Any other information that is important to this pull request.