Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

Commit cd73410

Browse files
mikeconleymikeconley
committed
Bug 1938452 - Update a bunch of non-permalink references to browser/extensions/newtab. r=sylvestre,search-reviewers,tabbrowser-reviewers,omc-reviewers,android-reviewers,home-newtab-reviewers,frontend-codestyle-reviewers,mcheang,pdahiya,thecount,dao,pollymce
Differential Revision: https://phabricator.services.mozilla.com/D233874
1 parent f6f68d8 commit cd73410

File tree

19 files changed

+48
-46
lines changed

19 files changed

+48
-46
lines changed

‎.eslintrc-ignores.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -69,10 +69,6 @@ module.exports = [
6969
"!browser/components/storybook/.storybook/",
7070
"!browser/components/storybook/.storybook/*.js",
7171

72-
// Ignore newtab files
73-
"browser/components/newtab/data/",
74-
"browser/components/newtab/logs/",
75-
7672
// Ignore webpack about:welcome files
7773
"browser/components/aboutwelcome/webpack.aboutwelcome.config.js",
7874

@@ -85,6 +81,10 @@ module.exports = [
8581
"browser/extensions/webcompat/data/injections.js",
8682
"browser/extensions/webcompat/data/ua_overrides.js",
8783

84+
// Ignore newtab files
85+
"browser/extensions/newtab/data/",
86+
"browser/extensions/newtab/logs/",
87+
8888
// Ignore devtools debugger files which aren't intended for linting.
8989
"devtools/client/debugger/bin/",
9090
"devtools/client/debugger/configs/",

‎.eslintrc-rollouts.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -330,6 +330,7 @@ const rollouts = [
330330
"browser/components/storybook/.storybook/**",
331331
"browser/components/tabbrowser/**",
332332
"browser/components/tests/browser/**",
333+
"browser/extensions/newtab/**",
333334
"browser/extensions/screenshots/**",
334335
"browser/modules/**",
335336
"devtools/**",
@@ -456,6 +457,7 @@ const rollouts = [
456457
"browser/components/translations/**",
457458
"browser/components/uitour/**",
458459
"browser/extensions/formautofill/**",
460+
"browser/extensions/newtab/**",
459461
"browser/extensions/pictureinpicture/**",
460462
"browser/extensions/report-site-issue/test/browser/head.js",
461463
"browser/extensions/search-detection/extension/background.js",

‎.eslintrc.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -277,8 +277,8 @@ module.exports = {
277277
files: [
278278
"browser/components/aboutwelcome/**",
279279
"browser/components/asrouter/**",
280-
"browser/components/newtab/**",
281280
"browser/components/pocket/**",
281+
"browser/extensions/newtab/**",
282282
"devtools/**",
283283
],
284284
rules: {

‎.stylelintignore

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,9 @@ obj*/
2525

2626
# These files are generated in some way.
2727
browser/components/pocket/content/panels/css/main.compiled.css
28-
browser/components/newtab/**/*.css
2928
browser/components/aboutwelcome/**/*.css
3029
browser/components/asrouter/**/*.css
30+
browser/extensions/newtab/**/*.css
3131

3232
# Note that the debugger has its own stylelint setup, but that currently
3333
# produces errors. Bug 1831302 tracks making this better

‎.stylelintrc.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -280,7 +280,7 @@ module.exports = {
280280
files: [
281281
"browser/components/aboutwelcome/**",
282282
"browser/components/asrouter/**",
283-
"browser/components/newtab/**",
283+
"browser/extensions/newtab/**",
284284
],
285285
customSyntax: "postcss-scss",
286286
extends: "stylelint-config-standard-scss",

‎browser/components/asrouter/bin/import-rollouts.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,7 @@ async function main() {
201201
202202
Examples
203203
$ node bin/import-rollouts.js --collection nimbus-preview
204-
$ ./mach npm run import-rollouts --prefix=browser/components/newtab -- -e
204+
$ ./mach npm run import-rollouts --prefix=browser/components/asrouter -- -e
205205
`,
206206
{
207207
description: false,

‎browser/components/asrouter/tests/browser/browser_feature_callout_in_chrome.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ const { DefaultBrowserCheck } = ChromeUtils.importESModule(
99
);
1010

1111
const PDF_TEST_URL =
12-
"https://example.com/browser/browser/components/newtab/test/browser/file_pdf.PDF";
12+
"https://example.com/browser/browser/extensions/newtab/test/browser/file_pdf.PDF";
1313

1414
async function openURLInWindow(window, url) {
1515
const { selectedBrowser } = window.gBrowser;

‎browser/extensions/newtab/bin/render-activity-stream-html.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ const DEFAULT_OPTIONS = {
1414
// Starting in newtab/bin/ and we want to write to newtab/prerendered/ so we
1515
// go up one level.
1616
addonPath: "..",
17-
// depends on the registration in browser/components/newtab/jar.mn
17+
// depends on the registration in browser/extensions/newtab/jar.mn
1818
baseUrl: "resource://activity-stream/",
1919
baseVendorUrl: "chrome://global/content/",
2020
};

‎browser/extensions/newtab/docs/index.rst

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ Firefox Home (New Tab)
33
======================
44

55
All files related to Firefox Home, which includes content that appears on ``about:home`` and
6-
``about:newtab``, can be found in the ``browser/components/newtab`` directory.
6+
``about:newtab``, can be found in the ``browser/extensions/newtab`` directory.
77
Some of these source files (such as ``.js``, ``.jsx``, and ``.scss``) require an additional build step.
88
We are working on migrating this to work with ``mach``, but in the meantime, please
99
follow the following steps if you need to make changes in this directory:
@@ -29,15 +29,15 @@ To install dependencies, run the following from the root of the mozilla-central
2929

3030
.. code-block:: shell
3131
32-
(cd browser/components/newtab && ../../../mach npm install)
32+
(cd browser/extensions/newtab && ../../../mach npm install)
3333
3434
3535
Which files should you edit?
3636
````````````````````````````
3737

38-
You should not make changes to ``.js`` or ``.css`` files in ``browser/components/newtab/css`` or
39-
``browser/components/newtab/data`` directory. Instead, you should edit the ``.jsx``, ``.js``, and ``.scss`` source files
40-
in ``browser/components/newtab/content-src`` directory. These files will be compiled into the ``.js`` and ``.css`` files.
38+
You should not make changes to ``.js`` or ``.css`` files in ``browser/extensions/newtab/css`` or
39+
``browser/extensions/newtab/data`` directory. Instead, you should edit the ``.jsx``, ``.js``, and ``.scss`` source files
40+
in ``browser/extensions/newtab/content-src`` directory. These files will be compiled into the ``.js`` and ``.css`` files.
4141

4242

4343
Building assets and running Firefox
@@ -47,11 +47,11 @@ To build assets and run Firefox, run the following from the root of the mozilla-
4747

4848
.. code-block:: shell
4949
50-
./mach npm run bundle --prefix=browser/components/newtab && ./mach build && ./mach run
50+
./mach npm run bundle --prefix=browser/extensions/newtab && ./mach build && ./mach run
5151
5252
Continuous development / debugging
5353
----------------------------------
54-
Running ``./mach npm run watchmc --prefix=browser/components/newtab`` will start a process that watches files in
54+
Running ``./mach npm run watchmc --prefix=browser/extensions/newtab`` will start a process that watches files in
5555
``activity-stream`` and rebuilds the bundled files when JS or CSS files change.
5656

5757
**IMPORTANT NOTE**: This task will add inline source maps to help with debugging, which changes the memory footprint.
@@ -68,7 +68,7 @@ red, these tests are what is failing. To execute them, do this:
6868

6969
.. code-block:: shell
7070
71-
./mach npm test --prefix=browser/components/newtab
71+
./mach npm test --prefix=browser/extensions/newtab
7272
7373
These tests are not currently run by ``mach test``, but there's a
7474
`task filed to fix that <https://bugzilla.mozilla.org/show_bug.cgi?id=1581165>`_.
@@ -80,9 +80,9 @@ To run newtab specific tests that aren't covered by ``mach lint`` and
8080

8181
.. code-block:: shell
8282
83-
./mach npm run lint:stylelint --prefix=browser/components/newtab
84-
./mach npm run testmc:build --prefix=browser/components/newtab
85-
./mach npm run testmc:unit --prefix=browser/components/newtab
83+
./mach npm run lint:stylelint --prefix=browser/extensions/newtab
84+
./mach npm run testmc:build --prefix=browser/extensions/newtab
85+
./mach npm run testmc:unit --prefix=browser/extensions/newtab
8686
8787
Mochitests and xpcshell tests run normally, using ``mach test``.
8888

@@ -96,8 +96,8 @@ running
9696

9797
.. code-block:: shell
9898
99-
./mach npm test --prefix=browser/components/newtab &&
100-
./mach npm run debugcoverage --prefix=browser/components/newtab
99+
./mach npm test --prefix=browser/extensions/newtab &&
100+
./mach npm run debugcoverage --prefix=browser/extensions/newtab
101101
102102
Discovery Stream Developer tools
103103
--------------------------------

‎browser/extensions/newtab/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@
6464
"repository": "mozilla/activity-stream",
6565
"config": {
6666
"mc_root": "../../..",
67-
"newtab_path": "browser/components/newtab"
67+
"newtab_path": "browser/extensions/newtab"
6868
},
6969
"scripts": {
7070
"bundle": "npm-run-all bundle:*",

0 commit comments

Comments
 (0)