Skip to content

Swift: Use actual device architecture for reporting #3367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
badboy wants to merge 1 commit into from
Closed

Swift: Use actual device architecture for reporting #3367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion glean-core/ios/Glean/Glean.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ public final class Glean: @unchecked Sendable {
appBuild: AppInfo.buildId,
appDisplayVersion: AppInfo.displayVersion,
appBuildDate: Datetime(from: buildInfo.buildDate),
architecture: Sysctl.machine,
architecture: Sysctl.architecture,
osVersion: UIDevice.current.systemVersion,
channel: configuration.channel,
locale: getLocaleTag(),
Expand Down
6 changes: 3 additions & 3 deletions glean-core/ios/Glean/Utils/Sysctl.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,9 +144,9 @@ struct Sysctl {
/// Always the same on Apple hardware
public static var manufacturer: String = "Apple"

/// e.g. "N71mAP"
public static var machine: String {
return (try? Sysctl.string(for: [CTL_HW, HW_MODEL])) ?? "Unknown"
/// e.g. "arm64"
public static var architecture: String {
return (try? Sysctl.string(for: [CTL_HW, HW_MACHINE_ARCH])) ?? "Unknown"
}

/// e.g. "iPhone8,1"
Expand Down