Move integration tests into a crate instead of shell scripts#3409
Open
Move integration tests into a crate instead of shell scripts#3409
Conversation
badboy
commented
Feb 24, 2026
| let symbol = libc::dlsym(libc::RTLD_NEXT, name); | ||
| if symbol.is_null() { | ||
| panic!("dlsym failed to load `pthread_create` name. Nothing we can do, we abort."); | ||
| unsafe { |
Member
Author
There was a problem hiding this comment.
This is now inside an edition = 2024 crate, so it requires the extra unsafe wrapping. Otherwise the code is unchanged.
Member
Author
|
I have not yet vetted the new dependencies (note that they are only deps of the new test crate, they won't end up in m-c) |
Member
Author
|
On 
With this patch: 
Rust tests stable: 8m 49s -> 6m 17s Of course times vary a bit, but 2-5minute reduction is significant. |
badboy
force-pushed
the
push-qlquumloxzmw
branch
from
c322414 to
5d37889
Compare
Member
Author
now vetted. |
This has multiple advantages: * Less bash * Less duplication of a hand-grown "testing harness" * It's faster! * It runs as part of a regular `make test-rust` run locally
badboy
force-pushed
the
push-qlquumloxzmw
branch
from
5d37889 to
8c890af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has multiple advantages:
make test-rustrun locally