-
Notifications
You must be signed in to change notification settings - Fork 166
Add multi-threading support for LLVM profile merging #1394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
asthetik
wants to merge
2
commits into
mozilla:master
Choose a base branch
from
asthetik:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -81,17 +81,25 @@ pub fn llvm_profiles_to_lcov( | |
| profile_paths: &[PathBuf], | ||
| binary_path: &Path, | ||
| working_dir: &Path, | ||
| num_threads: Option<usize>, | ||
| ) -> Result<Vec<Vec<u8>>, String> { | ||
| let profdata_path = working_dir.join("grcov.profdata"); | ||
|
|
||
| let args = vec![ | ||
| let mut args = vec![ | ||
| "merge".as_ref(), | ||
| "-f".as_ref(), | ||
| "-".as_ref(), | ||
| "-sparse".as_ref(), | ||
| "-o".as_ref(), | ||
| profdata_path.as_ref(), | ||
| ]; | ||
| let num_threads_str: String; | ||
| // Only pass --num-threads if explicitly specified by the user | ||
| if let Some(num) = num_threads { | ||
| num_threads_str = num.to_string(); | ||
| args.push("--num-threads".as_ref()); | ||
| args.push(num_threads_str.as_ref()); | ||
| } | ||
|
Comment on lines
+96
to
+102
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you refactor this to be nicer? if let Some(num) = num_threads {
args.push("--num-threads".to_string());
args.push(num.to_string());
} |
||
|
|
||
| let stdin_paths: String = profile_paths.iter().fold("".into(), |mut a, x| { | ||
| a.push_str(x.to_string_lossy().as_ref()); | ||
|
|
@@ -107,14 +115,21 @@ pub fn llvm_profiles_to_lcov( | |
| let results = binaries | ||
| .into_par_iter() | ||
| .filter_map(|binary| { | ||
| let args = [ | ||
| let mut args = vec![ | ||
| "export".as_ref(), | ||
| binary.as_ref(), | ||
| "--instr-profile".as_ref(), | ||
| profdata_path.as_ref(), | ||
| "--format".as_ref(), | ||
| "lcov".as_ref(), | ||
| ]; | ||
| let num_threads_str: String; | ||
| // Only pass --num-threads if explicitly specified by the user | ||
| if let Some(num) = num_threads { | ||
| num_threads_str = num.to_string(); | ||
| args.push("--num-threads".as_ref()); | ||
| args.push(num_threads_str.as_ref()); | ||
| } | ||
|
|
||
| match run(&cov_tool_path, &args) { | ||
| Ok(result) => Some(result), | ||
|
|
@@ -301,6 +316,7 @@ mod tests { | |
| &[tmp_path.join("default.profraw")], | ||
| &PathBuf::from("src"), // There is no binary file in src | ||
| tmp_path, | ||
| None, | ||
| ); | ||
| assert!(lcovs.is_ok()); | ||
| let lcovs = lcovs.unwrap(); | ||
|
|
@@ -317,6 +333,7 @@ mod tests { | |
| &[tmp_path.join("default.profraw")], | ||
| &tmp_path.join(binary_path), | ||
| tmp_path, | ||
| None, | ||
| ); | ||
| assert!(lcovs.is_ok(), "Error: {}", lcovs.unwrap_err()); | ||
| let lcovs = lcovs.unwrap(); | ||
|
|
@@ -349,7 +366,12 @@ mod tests { | |
|
|
||
| assert_eq!(status.unwrap().code().unwrap(), 0); | ||
|
|
||
| let lcovs = llvm_profiles_to_lcov(&[profdata_path], &tmp_path.join(binary_path), tmp_path); | ||
| let lcovs = llvm_profiles_to_lcov( | ||
| &[profdata_path], | ||
| &tmp_path.join(binary_path), | ||
| tmp_path, | ||
| None, | ||
| ); | ||
|
|
||
| assert!(lcovs.is_ok(), "Error: {}", lcovs.unwrap_err()); | ||
| let lcovs = lcovs.unwrap(); | ||
|
|
@@ -396,6 +418,7 @@ mod tests { | |
| &[path_with, path_without], | ||
| &tmp_path.join(bin_path), | ||
| tmp_path, | ||
| None, | ||
| ); | ||
|
|
||
| assert!(lcovs.is_ok(), "Error: {}", lcovs.unwrap_err()); | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -451,6 +451,7 @@ fn main() { | |
| let branch_enabled = opt.branch; | ||
| let guess_directory = opt.guess_directory; | ||
| let ignore_parsing_error = opt.ignore_parsing_error; | ||
| let llvm_threads = opt.threads; | ||
|
|
||
| let t = thread::Builder::new() | ||
| .name(format!("Consumer {i}")) | ||
|
|
@@ -465,6 +466,7 @@ fn main() { | |
| guess_directory, | ||
| binary_path.as_deref(), | ||
| ignore_parsing_error, | ||
| llvm_threads, | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just pass opt.threads and avoid defining an intermediate variable |
||
| ); | ||
| }) | ||
| .unwrap(); | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd call this num_threads