Skip to content

Ensure execute bits are cleared after pull#25

Merged
gene1wood merged 1 commit intomozilla:mainfrom
gene1wood:set_perms_after_pull
Nov 10, 2025
Merged

Ensure execute bits are cleared after pull#25
gene1wood merged 1 commit intomozilla:mainfrom
gene1wood:set_perms_after_pull

Conversation

@gene1wood
Copy link
Collaborator

As some USB stick filesystems don't support file permissions, after copying files from the stick they may have their execute bit set on owner/group/other.

This clears those execute bits. No further mode modifications are made as git doesn't retain anything beyond the presence or absence of the execute bits.

  • Factor the setup of the testing USB stick into its own function to avoid duplicating code
  • Explicitly test for the presence of certs_issued/test directory

Fixes #14

As some USB stick filesystems don't support file permissions, after copying
files from the stick they may have their execute bit set on owner/group/other.

This clears those execute bits. No further mode modifications are made as git
doesn't retain anything beyond the presence or absence of the execute bits.

* Factor the setup of the testing USB stick into its own function to avoid
  duplicating code
* Explicitly test for the presence of certs_issued/test directory

Fixes mozilla#14
@gene1wood gene1wood merged commit f42cb11 into mozilla:main Nov 10, 2025
3 checks passed
@gene1wood gene1wood deleted the set_perms_after_pull branch November 10, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update pull-from-stick to set permissions on files after copying them to the repo because they’ll likely be 755 coming from exfat

1 participant