Skip to content

Add ability to remove items from the queue by identifier #1029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 18, 2024
Merged

Add ability to remove items from the queue by identifier #1029

merged 6 commits into from
Jul 18, 2024

Conversation

grahamalama
Copy link
Contributor

No description provided.

@grahamalama grahamalama requested a review from a team as a code owner July 17, 2024 17:00
@grahamalama grahamalama added the enhancement New feature or request label Jul 17, 2024
leplatrem
leplatrem approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@leplatrem leplatrem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could add this new endpoint to the test test_get_protected_endpoints()

@grahamalama
Copy link
Contributor Author

@leplatrem good call, though instead of adding a case to that test, I added a new test_delete_queue_item_by_id_requires_authn.

@grahamalama grahamalama merged commit eec3737 into main Jul 18, 2024
5 checks passed
@grahamalama grahamalama deleted the delete-queue-items branch July 18, 2024 15:39
davehunt pushed a commit to davehunt/jira-bugzilla-integration that referenced this pull request Jan 29, 2025
@grahamalama @davehunt
Add ability to remove items from the queue by identifier (mozilla#1029)
192001f 
Also:

* Fix warning about invalid escape sequence in the queue's `get_all` method

* Move queue test module out of `jira` test subdir
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leplatrem leplatrem leplatrem approved these changes

@alexcottner alexcottner alexcottner approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grahamalama @leplatrem @alexcottner