Skip to content

Show method + URL on Jira exceptions #1101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Show method + URL on Jira exceptions #1101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion jbi/jira/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ def raise_for_status(self, *args, **kwargs):
extra={"body": response.text},
)
# Set the exception message so that its str version contains details.
msg = f"HTTP {exc.response.status_code}: {exc}"
msg = f"{request.method} {request.path_url} -> HTTP {response.status_code}: {exc}"
exc.args = (msg,) + exc.args[1:]
raise

Expand Down
5 changes: 4 additions & 1 deletion tests/unit/test_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,7 +375,10 @@ async def test_execute_or_queue_http_error_details(

items = (await dl_queue.retrieve())[bug.id]
[item] = [i async for i in items]
assert item.error.description == "HTTP 400: Field 'resolution' cannot be set."
assert (
item.error.description
== "POST /rest/api/2/issue/TEST-1/remotelink -> HTTP 400: Field 'resolution' cannot be set."
)


def test_default_invalid_init():
Expand Down
Loading