Skip to content

Run multiple actions when multiple whiteboard tags #1109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 6, 2025

Conversation

Dexterp37
Copy link
Contributor

@Dexterp37 Dexterp37 commented Feb 21, 2025

This PR attempts to fix #708 and similar issues. I added a few tests to build some confidence in the code, but would be great to actually test this in a staging environment.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Feb 21, 2025
Copy link
Contributor

@alexcottner alexcottner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a good direction and is a simple way to solve this problem without needing to change our config model significantly.

This additionally adds a test that verifies
actions are properly detected and executed.
@Dexterp37
Copy link
Contributor Author

I think this is a good direction and is a simple way to solve this problem without needing to change our config model significantly.

Thanks! I'm glad and I hope this ends up working the way we expect!

@Dexterp37 Dexterp37 marked this pull request as ready for review February 26, 2025 10:08
@Dexterp37 Dexterp37 requested a review from a team as a code owner February 26, 2025 10:08
Copy link
Contributor

@leplatrem leplatrem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct!

I only have one concern, but it may be covered already with existing code.

When an event occurs on a bz ticket, we may end up adding several "see also" links to different Jira issues (one per action).

This code picks the first one that matches the specified project:

return candidates[0] if candidates else None

I was wondering whether we could have a test that makes sure, when different Jira issues are associated to a project, that the update event is well applied to the respective project.

Would it superfluous? What do you think?

Otherwise, :shipit:

@Dexterp37
Copy link
Contributor Author

When an event occurs on a bz ticket, we may end up adding several "see also" links to different Jira issues (one per action).

This code picks the first one that matches the specified project:

return candidates[0] if candidates else None

I was wondering whether we could have a test that makes sure, when different Jira issues are associated to a project, that the update event is well applied to the respective project.

Would it superfluous? What do you think?

I think this is a good test to have, I'm ok with adding it. Let me see if I can do this!

This adds an additional test to make sure that actions
are dispatched to the appropriate project.
@Dexterp37 Dexterp37 requested a review from leplatrem March 5, 2025 12:33
Copy link
Contributor

@leplatrem leplatrem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Alessio!

@leplatrem leplatrem merged commit 0a9bedf into mozilla:main Mar 6, 2025
5 checks passed
@Dexterp37 Dexterp37 deleted the multi-whiteboard branch March 6, 2025 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature request: ability to have multiple bz whiteboard tags
3 participants