-
Notifications
You must be signed in to change notification settings - Fork 24
Run multiple actions when multiple whiteboard tags #1109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a good direction and is a simple way to solve this problem without needing to change our config model significantly.
This additionally adds a test that verifies actions are properly detected and executed.
Thanks! I'm glad and I hope this ends up working the way we expect! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks correct!
I only have one concern, but it may be covered already with existing code.
When an event occurs on a bz ticket, we may end up adding several "see also" links to different Jira issues (one per action).
This code picks the first one that matches the specified project:
return candidates[0] if candidates else None |
I was wondering whether we could have a test that makes sure, when different Jira issues are associated to a project, that the update event is well applied to the respective project.
Would it superfluous? What do you think?
Otherwise,
I think this is a good test to have, I'm ok with adding it. Let me see if I can do this! |
This adds an additional test to make sure that actions are dispatched to the appropriate project.
35304e6
to
2c08424
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Alessio!
This PR attempts to fix #708 and similar issues. I added a few tests to build some confidence in the code, but would be great to actually test this in a staging environment.