Fix #2437: The current panel will not be added to the history if it’s already the last panel #2674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…’s already the last panel
axshaykp
changed the title
dannycolin
requested changes
Oct 19, 2024
|
|
||
| async showPanel(panel, currentIdentity = null, backwards = false, addToPreviousPanelPath = true) { | ||
| if ((!backwards && addToPreviousPanelPath) || !this._currentPanel) { | ||
| if ((!backwards && addToPreviousPanelPath) && this._currentPanel && this._currentPanel !== panel) { |
Collaborator
There was a problem hiding this comment.
While the change seems to work in this specific step-to-reproduce, it introduces an issue in the conditional logic in the following scenario:
- Open popup to show containerList
- Click on the right arrow of the Personal container to go to the containerInfo panel
- In containerInfo panel, click on "manage this container" button
- In containerEdit panel, click on the back button to go to the previous panel containerInfo
- In containerInfo panel, click on the back button to go to the previous panel containerList
On the last step, backwards value is set to false but it should be set to true since we clicked on the back button.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting your pull request
npm testand all tests passed.Description
Duplicate entries in the previous panel path were preventing the back button from navigating to the previous panel, which hindered container editing.
Type of change
Select all that apply.
Tag issues related to this pull request: