Fix build for removal of firefox-{beta,devedition}-bin from nixpkgs #344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NixOS/nixpkgs#414510 Signed-off-by: Anders Kaseorg <[email protected]>
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
Author
|
That’s not “also”, that’s the whole point of my PR. But it was removed in the commit I linked, not the one you linked (yours is just the update script). |
|
Sorry, I misinterpreted the diff. I assumed |
c2fc2f
approved these changes
Jun 20, 2025
|
Any updates? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has an unfortunate side effect of renaming the
firefox-beta,firefox-devedition,firefox-nightlybinaries tofirefoxon affected nixpkgs versions.