Skip to content

Conversation

@legraina
Copy link

@legraina legraina commented Aug 30, 2025

I have created a different PR as requested.

Move current pointer field of DrawingEditor to CurrentPointer class in tools.js. Also, only reset pointer type when user select a new mode.

  • PointerType:
    • The pointer types fields have been moved to a CurrentPointer object in tools.js. This object is used by eraser.js and ink.js
    • Clear the pointer type when changing mode, instead of at the end of the session. It seems more stable, as the method is not called this way when the user changes pages.
    • Only clear the pointer type when the mode is changed by an event (the user changes the editor type), otherwise, the same pointer type is kept (the document is changed for example).

@legraina legraina mentioned this pull request Aug 30, 2025
10 tasks
@calixteman
Copy link
Contributor

Please update the title of the PR to precise its goal in few words.

@legraina legraina changed the title CurrentPointer A new CurrentPointers class to store current pointers used by the editor Sep 3, 2025
Copy link
Author

@legraina legraina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made most of the modifications asked.

@legraina legraina changed the title A new CurrentPointers class to store current pointers used by the editor [Editor] A new CurrentPointers class to store current pointers used by the editor Sep 3, 2025
@legraina
Copy link
Author

legraina commented Sep 9, 2025

Hi @calixteman, everything looks good ? Or anything else to change/improve ? Thanks

@calixteman
Copy link
Contributor

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/1daf869439e6efa/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/95a4007ba862abb/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/1daf869439e6efa/output.txt

Total script time: 19.64 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/95a4007ba862abb/output.txt

Total script time: 45.51 mins

  • Integration Tests: Passed

@calixteman
Copy link
Contributor

@legraina could you rebase and squash your PR please ?

@legraina
Copy link
Author

@legraina could you rebase and squash your PR please ?

@calixteman Done

@timvandermeij
Copy link
Contributor

timvandermeij commented Oct 21, 2025

Please fix the commit message to have a descriptive title and body so that when reading the git log output it's easy to tell what the change was and why it was introduced.

In general I can recommend https://cbea.ms/git-commit/ which explains how to write good commit messages and why that matters.

Move current pointer field of DrawingEditor to CurrentPointer class in tools.js: The pointer types fields have been moved to a CurrentPointer object in tools.js. This object is used by eraser.js and ink.js.
Only reset pointer type when user select a new mode: Clear the pointer type when changing mode, instead of at the end of the session. It seems more stable, as the method is not called this way when the user changes pages. Also, clear the pointer type when the mode is changed by an event (the user changes the editor type), otherwise, the same pointer type is kept (the document is changed for example)
@legraina
Copy link
Author

@timvandermeij, it's done. Is it better ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants