-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[Editor] A new CurrentPointers class to store current pointers used by the editor #20213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Please update the title of the PR to precise its goal in few words. |
2787e48 to
7e3b3ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made most of the modifications asked.
|
Hi @calixteman, everything looks good ? Or anything else to change/improve ? Thanks |
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/1daf869439e6efa/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/95a4007ba862abb/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/1daf869439e6efa/output.txt Total script time: 19.64 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/95a4007ba862abb/output.txt Total script time: 45.51 mins
|
|
@legraina could you rebase and squash your PR please ? |
a98bb89 to
3a82570
Compare
@calixteman Done |
|
Please fix the commit message to have a descriptive title and body so that when reading the In general I can recommend https://cbea.ms/git-commit/ which explains how to write good commit messages and why that matters. |
Move current pointer field of DrawingEditor to CurrentPointer class in tools.js: The pointer types fields have been moved to a CurrentPointer object in tools.js. This object is used by eraser.js and ink.js. Only reset pointer type when user select a new mode: Clear the pointer type when changing mode, instead of at the end of the session. It seems more stable, as the method is not called this way when the user changes pages. Also, clear the pointer type when the mode is changed by an event (the user changes the editor type), otherwise, the same pointer type is kept (the document is changed for example)
3a82570 to
a932804
Compare
|
@timvandermeij, it's done. Is it better ? |
I have created a different PR as requested.
Move current pointer field of DrawingEditor to CurrentPointer class in tools.js. Also, only reset pointer type when user select a new mode.