Skip to content

Collect all child nodes of lists and tables in StructTree #20327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+47 −0
Open

Collect all child nodes of lists and tables in StructTree #20327

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f53ab29
Collect all child nodes of lists and tables
edoardocavazza Oct 2, 2025
38cc9ae
Add test case for empty cells
edoardocavazza Oct 6, 2025
2146cb2
Move tables test to specific struct tree spec file
edoardocavazza Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions src/core/struct_tree.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -754,6 +754,23 @@ class StructTreePage {

const element = new StructElementNode(this, dict);
map.set(dict, element);
switch (element.role) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test to make sure that this behavior can't regress in the future.

case "L":
case "LBody":
case "LI":
case "Table":
case "THead":
case "TBody":
case "TFoot":
case "TR": {
// Always collect all child nodes of lists and tables, even empty ones
for (const kid of element.kids) {
if (kid.type === StructElementType.ELEMENT) {
this.addNode(kid.dict, map, level - 1);
}
}
}
}

const parent = dict.get("P");

Expand Down