Skip to content

migrated-Frontend-test-under-entitiesList,-entitydetails-and-historyTranslation to RTL#3992

Merged
eemeli merged 5 commits intomozilla:mainfrom
nishitmistry:migrated-Frontend-test-under-entitiesList,-entitydetails-and-historyTranslation
Mar 11, 2026
Merged

migrated-Frontend-test-under-entitiesList,-entitydetails-and-historyTranslation to RTL#3992
eemeli merged 5 commits intomozilla:mainfrom
nishitmistry:migrated-Frontend-test-under-entitiesList,-entitydetails-and-historyTranslation

Conversation

@nishitmistry
Copy link
Collaborator

@mathjazz
Copy link
Collaborator

mathjazz commented Mar 5, 2026

Hi @nishitmistry Are you still working on this? If not, please request a review from Eemeli.

@nishitmistry
Copy link
Collaborator Author

Hi @nishitmistry Are you still working on this? If not, please request a review from Eemeli.

Hey @mathjazz, @eemeli , this pr is ready to be reviewed. i can't assign a reviewer to my PRs maybe its because of some repository settings, can you please look into what can be done for open source contributor like me.

@mathjazz mathjazz requested a review from eemeli March 5, 2026 12:00
@mathjazz
Copy link
Collaborator

mathjazz commented Mar 5, 2026

Thanks! Sent you an invite to become a collaborator on the project.

@nishitmistry
Copy link
Collaborator Author

Thanks! Sent you an invite to become a collaborator on the project.

@mathjazz, Thanks for the invitation, i have accept it. i am looking forward to work on different issues in the project :).

P.S i promise i won't dump any AI slop XD.

Copy link
Member

@eemeli eemeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good; see inline for a few fixes.

<li
className={cn}
role='button'
aria-label={'Select "{ $original }" for translation.'}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably best to leave this backup assignment out, esp. given the $original placeholder. The formatted value should be getting overridden by the <Localized> in any case.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohk, removed the fallback aria-label

@nishitmistry nishitmistry requested a review from eemeli March 11, 2026 12:13
Copy link
Member

@eemeli eemeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@eemeli eemeli merged commit fea692b into mozilla:main Mar 11, 2026
6 checks passed
@nishitmistry nishitmistry deleted the migrated-Frontend-test-under-entitiesList,-entitydetails-and-historyTranslation branch March 11, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants