migrated-Frontend-test-under-entitiesList,-entitydetails-and-historyTranslation to RTL#3992
Conversation
nishitmistry
commented
Feb 24, 2026
- Continuation of previous MR migrate test under /context, /batchactions, / comments, /diff, /editor to rtl #3988 the migration of enzyme test to @testing-library/react under task Move remaining enzyme tests to @testing-library/react #3767
|
Hi @nishitmistry Are you still working on this? If not, please request a review from Eemeli. |
Hey @mathjazz, @eemeli , this pr is ready to be reviewed. i can't assign a reviewer to my PRs maybe its because of some repository settings, can you please look into what can be done for open source contributor like me. |
|
Thanks! Sent you an invite to become a collaborator on the project. |
@mathjazz, Thanks for the invitation, i have accept it. i am looking forward to work on different issues in the project :). P.S i promise i won't dump any AI slop XD. |
eemeli
left a comment
There was a problem hiding this comment.
Looks pretty good; see inline for a few fixes.
| <li | ||
| className={cn} | ||
| role='button' | ||
| aria-label={'Select "{ $original }" for translation.'} |
There was a problem hiding this comment.
Probably best to leave this backup assignment out, esp. given the $original placeholder. The formatted value should be getting overridden by the <Localized> in any case.
There was a problem hiding this comment.
ohk, removed the fallback aria-label