Skip to content

Commit 5384033

Browse files
committed
(Partial) Revert "bug 1877836 - Remove GeckoView Streaming Telemetry"
This reverts commit 4559963. This currently breaks at the very least update tasks like the push mode, due to the metrics still being there in the other component, even though they are "gone".
1 parent 4559963 commit 5384033

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

probe_scraper/glean_checks.py

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -137,9 +137,13 @@ def check_for_duplicate_metrics(repositories, metrics_by_repo, emails):
137137
if metric["history"][-1]["dates"]["last"] == last_timestamp:
138138
metric_sources.setdefault(metric_name, []).append(dependency)
139139

140-
duplicate_sources = dict(
141-
(k, v) for (k, v) in metric_sources.items() if len(v) > 1
142-
)
140+
duplicate_sources = {}
141+
for (k, v) in metric_sources.items():
142+
# Exempt cases when one of the sources is Geckoview Streaming to
143+
# avoid false positive duplication accross app channels.
144+
v = [dep for dep in v if "engine-gecko" not in dep]
145+
if len(v) > 1:
146+
duplicate_sources[k] = v
143147

144148
if not len(duplicate_sources):
145149
continue

0 commit comments

Comments
 (0)