-
Notifications
You must be signed in to change notification settings - Fork 62
Add subplat-cirrus to repositories.yaml #963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
relud
wants to merge
2
commits into
mozilla:main
Choose a base branch
from
relud:patch-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+21
−0
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2121,3 +2121,24 @@ applications: | |
| moz_pipeline_metadata_defaults: | ||
| expiration_policy: | ||
| delete_after_days: 760 | ||
|
|
||
| - app_name: subplat_cirrus | ||
| canonical_app_name: "Subscription Platform (Cirrus)" | ||
| app_description: | | ||
| Mozilla Subscription Platform is Mozilla's subscription management | ||
| solution for account-based end-user services and features. | ||
| url: https://github.com/mozilla/fxa | ||
| notification_emails: | ||
| - [email protected] | ||
| branch: main | ||
| metrics_files: [] | ||
| ping_files: [] | ||
| dependencies: | ||
| - glean-server | ||
| - nimbus-cirrus | ||
| channels: | ||
| - v1_name: subplat-cirrus | ||
| app_id: subplat.cirrus | ||
| moz_pipeline_metadata_defaults: | ||
| expiration_policy: | ||
| delete_after_days: 760 | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question (non-blocking): Based on the dependencies including
glean-server, is this perhaps intended to be specific to the SubPlat backend? Or would it also be used for the SubPlat frontend?If it is specific to the SubPlat backend, then I think it'd be good to change the
app_name,v1_name, andapp_idto be more similar to the values for the existingsubscription_platform_backendapp (plus the appropriate Cirrus-specific suffix).Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tl;dr this isn't backend specific
More precisely, while we expect only the backend to use it, we expect any experiments in the frontend to receive feature configuration from the backend, not directly from cirrus. This matches with
accounts_cirruswhich is also only used in the backend.integrating with cirrus on the frontend would be for applications that don't have a suitable backend, e.g. static sites that only have client-side code.