-
Notifications
You must be signed in to change notification settings - Fork 604
Disable reqwest default features to not depend on openssl #2421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
sorry but it needs to be rebased |
@sylvestre done |
|
fails with: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2421 +/- ##
==========================================
- Coverage 71.22% 67.97% -3.25%
==========================================
Files 64 64
Lines 35214 34723 -491
==========================================
- Hits 25080 23602 -1478
- Misses 10134 11121 +987 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@sylvestre I think I have everything downgraded that is incompatible with 1.75 |
|
Turns out updating with an older version requirement is just too hard, especially when I can't test out the windows stuff, so I'm downgrading this to just the one change to remove the default dependencies for reqwest. |
|
@sylvestre I just updated this again. Maybe the tests will pass this time after all the other crate updates. |
Fixes #841
I also did a cargo update to get the latest dependencies. All the tests were able to build, and I did get a failure locally, but probably due to my setup.