Skip to content

Add constants defined headers to the .cc files as builds currently fa… #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lissyx wants to merge 1 commit into
base: r2.3
Choose a base branch
from
Open

Add constants defined headers to the .cc files as builds currently fa… #125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions tensorflow/core/kernels/data/experimental/io_ops.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,11 @@ namespace tensorflow {
namespace data {
namespace experimental {

/* static */ constexpr const int SaveDatasetOp::kFileFormatVersion;
/* static */ constexpr const char* const LoadDatasetOp::kCompression;
/* static */ constexpr const char* const LoadDatasetOp::kReaderFunc;
/* static */ constexpr const char* const LoadDatasetOp::kReaderFuncTarguments;

SaveDatasetOp::SaveDatasetOp(OpKernelConstruction* ctx)
: HybridAsyncOpKernel(ctx, "tf_data_save_dataset") {
OP_REQUIRES_OK(ctx, ctx->GetAttr(kCompression, &compression_));
Expand Down
13 changes: 10 additions & 3 deletions tensorflow/core/kernels/data/experimental/snapshot_dataset_op.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,15 @@ namespace tensorflow {
namespace data {
namespace experimental {

/* static */ constexpr const char* const SnapshotDatasetV2Op::kCompression;
/* static */ constexpr const char* const SnapshotDatasetV2Op::kReaderFunc;
/* static */ constexpr const char* const SnapshotDatasetV2Op::kShardFunc;
/* static */ constexpr const char* const
SnapshotDatasetV2Op::kReaderFuncTarguments;
/* static */ constexpr const char* const
SnapshotDatasetV2Op::kShardFuncTarguments;
/* static */ constexpr const int SnapshotDatasetV2Op::kFileFormatVersion;

// ==== Snapshot Implementation ====

/* The current snapshot on-disk layout is as follows:
Expand Down Expand Up @@ -1122,9 +1131,7 @@ class SnapshotDatasetOp : public UnaryDatasetOpKernel {
// Initialize at first and at that point we don't know which iterator
// (Reader / Writer / Passthrough) we need to restore as this info is part
// of the checkpoint.
Status Initialize(IteratorContext* ctx) override {
return Status::OK();
}
Status Initialize(IteratorContext* ctx) override { return Status::OK(); }

Status GetNextInternal(IteratorContext* ctx,
std::vector<Tensor>* out_tensors,
Expand Down