feat: Map product position to Firebase item index #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -536,6 +536,10 @@ - (NSMutableArray *)getParametersForProducts:(id)products { | |||
| if (product.price) { | |||
| [productParameters setObject:product.price forKey:kFIRParameterPrice]; | |||
| } | |||
| if (product.position) { | |||
| id indexParameter = @(product.position); | |||
There was a problem hiding this comment.
any reason you defined this as id instead of NSNumber * ?
There was a problem hiding this comment.
@BrandonStalnaker - it was throwing an error that I think it needs to be an id in order to pass
BrandonStalnaker
merged commit b3bdfb5
into
mparticle-integrations:development
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing Plan
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)