Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cartfile
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
binary "https://dl.google.com/dl/firebase/ios/carthage/FirebaseAnalyticsBinary.json" ~> 11.8
binary "https://dl.google.com/dl/firebase/ios/carthage/FirebaseAnalyticsBinary.json" ~> 12.0
binary "https://raw.githubusercontent.com/mParticle/mparticle-apple-sdk/main/mParticle_Apple_SDK.json" ~> 8.0

6 changes: 3 additions & 3 deletions Package.swift
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
// swift-tools-version:5.3
// swift-tools-version: 6.0
// The swift-tools-version declares the minimum version of Swift required to build this package.

import PackageDescription

let package = Package(
name: "mParticle-Google-Analytics-Firebase-GA4",
platforms: [ .iOS(.v13), .tvOS(.v13) ],
platforms: [ .iOS(.v15), .tvOS(.v15) ],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that the other PR does not include tvOS. i am seeing that firebase and firebase ga4 both do support though. maybe it was left out of the firebase repo unintentionally when first set up?

cc @BrandonStalnaker

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tvOS integration will be addressed in a follow-up ticket to ensure we cover all supported platforms.

products: [
.library(
name: "mParticle-Google-Analytics-Firebase-GA4",
Expand All @@ -20,7 +20,7 @@ let package = Package(
.upToNextMajor(from: "8.22.0")),
.package(name: "Firebase",
url: "https://github.com/firebase/firebase-ios-sdk.git",
.upToNextMajor(from: "11.8.0")),
.upToNextMajor(from: "12.0.0")),
],
targets: [
.target(
Expand Down
8 changes: 4 additions & 4 deletions mParticle-Google-Analytics-Firebase-GA4.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -14,20 +14,20 @@ Pod::Spec.new do |s|
s.social_media_url = "https://twitter.com/mparticle"
s.static_framework = true

s.ios.deployment_target = "13.0"
s.ios.deployment_target = "15.0"
s.ios.source_files = 'mParticle-Google-Analytics-Firebase-GA4/*.{h,m,mm}'
s.ios.resource_bundles = { 'mParticle-Google-Analytics-Firebase-GA4-Privacy' => ['mParticle-Google-Analytics-Firebase-GA4/PrivacyInfo.xcprivacy'] }
s.ios.dependency 'mParticle-Apple-SDK/mParticle', '~> 8.22'
s.ios.frameworks = 'CoreTelephony', 'SystemConfiguration'
s.libraries = 'z'
s.ios.dependency 'Firebase/Core', '~> 11.8'
s.ios.dependency 'Firebase/Core', '~> 12.0'

s.tvos.deployment_target = "13.0"
s.tvos.deployment_target = "15.0"
s.tvos.source_files = 'mParticle-Google-Analytics-Firebase-GA4/*.{h,m,mm}'
s.ios.resource_bundles = { 'mParticle-Google-Analytics-Firebase-GA4-Privacy' => ['mParticle-Google-Analytics-Firebase-GA4/PrivacyInfo.xcprivacy'] }
s.tvos.dependency 'mParticle-Apple-SDK/mParticle', '~> 8.22'
s.tvos.frameworks = 'SystemConfiguration'
s.libraries = 'z'
s.tvos.dependency 'Firebase/Core', '~> 11.8'
s.tvos.dependency 'Firebase/Core', '~> 12.0'

end