Fix product.position condition to handle zero values #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmustafa-tse
approved these changes
Aug 7, 2025
There was a problem hiding this comment.
LGTM! the only thing I would ask if possible to make a unit test for the position = 0 condition? @BrandonStalnaker let us know if anything else needed
BrandonStalnaker
merged commit fe8f65f
into
mparticle-integrations:development
1 of 3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instructions
developmentSummary
The fix ensures that when product.position = 0 is set, it will be properly included in Firebase GA4 parameters instead of being skipped.
Testing Plan
I tested it with my own app, adding the dependency via podfile from my github repo
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)