Skip to content

Fix product.position condition to handle zero values #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 13, 2025
Merged

Fix product.position condition to handle zero values #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eb9eb02
Fix product.position condition to handle zero values
Aug 4, 2025
52a3f8a
Since NSUInteger is a primitive type, there's no concept of "null"
Aug 4, 2025
049e10f
Add unit test for product.position = 0
Aug 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mParticle-Google-Analytics-Firebase-GA4/MPKitFirebaseGA4Analytics.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -536,7 +536,7 @@ - (NSMutableArray *)getParametersForProducts:(id)products {
if (product.price) {
[productParameters setObject:product.price forKey:kFIRParameterPrice];
}
if (product.position) {
if (product.position >= 0) {
id indexParameter = @(product.position);
[productParameters setObject:indexParameter forKey:kFIRParameterIndex];
}
Expand Down
21 changes: 21 additions & 0 deletions mParticle-Google-Analytics-Firebase-GA4Tests/MPKitFirebaseGA4AnalyticsTests.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,6 +312,27 @@ - (void)testProductParameters {
XCTAssertEqual([item count], 9);
}

- (void)testProductPositionEqualZero {
MPKitFirebaseGA4Analytics *exampleKit = [[MPKitFirebaseGA4Analytics alloc] init];
[exampleKit didFinishLaunchingWithConfiguration:@{}];

MPProduct *product = [[MPProduct alloc] initWithName:@"expensivePotato" sku:@"SKU123" quantity:@1 price:@40.0];
NSMutableDictionary<NSString *, id> *testProductCustomAttributes = [[@{@"productCustomAttribute": @"potato", @"store": @"Target"} mutableCopy] mutableCopy];
product.brand = @"LV";
product.category = @"vegetable";
product.position = 0;
product.userDefinedAttributes = testProductCustomAttributes;

MPCommerceEvent *event = [[MPCommerceEvent alloc] initWithImpressionName:@"suggested products list" product:product];
NSSet<MPProduct *> *impressionProducts = event.impressions[@"suggested products list"];

NSArray *itemsArray = [exampleKit getParametersForProducts:impressionProducts];
id item = itemsArray[0];

// The item inside itemsArray should include 9 parameters in total including the 2 product custom attributes
XCTAssertEqual([item count], 9);
}

- (void)testCommerceEventCheckoutOptions {
MPKitFirebaseGA4Analytics *exampleKit = [[MPKitFirebaseGA4Analytics alloc] init];
[exampleKit didFinishLaunchingWithConfiguration:@{}];
Expand Down
Loading