Skip to content

Conversation

nickolas-dimitrakas
Copy link
Contributor

Summary

  • This change refactors consent resolution logic in MPKitFirebaseGA4Analytics to improve clarity and testability

Testing Plan

  • Was this tested locally? If not, explain why.
  • All tests pass locally in Xcode

Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)

@nickolas-dimitrakas nickolas-dimitrakas marked this pull request as ready for review September 15, 2025 18:07
Copy link
Contributor

@denischilik denischilik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nickolas-dimitrakas nickolas-dimitrakas merged commit 2b47ff3 into development Sep 17, 2025
3 checks passed
@nickolas-dimitrakas nickolas-dimitrakas deleted the test/add-unit-tests-for-consent-mapping-logic branch September 17, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants