-
Notifications
You must be signed in to change notification settings - Fork 2
Add handle serialization routines #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@hzhou We need these new routines in MPICH. |
|
@jeffhammond In the new MPI std document we have "It is erroneous to call this function with an invalid handle argument". However, these routines do not follow the usual "return error code" pattern, and therefore is not clear at all how error handling should be implemented and eventually handled by users. IMHO, this should be amended following the model of c2f/f2c routines, that is, a) null handles can be properly mapped back and forth, but invalid MPI handles are mapped to invalid C int handles and vice versa. If an MPI implementation can afford the overhead of distinguishing valid vs invalid handles via some internal mechanism, then the |
Sync up mpi_abi.h from upstream - mpi-forum/mpi-abi-stubs#39
Sync up mpi_abi.h from upstream - mpi-forum/mpi-abi-stubs#39
|
We say it is erroneous to place the burden of checking entirely on the user, to allow trivial implementations. |
OK, I clearly misunderstood the actual meaning. |
Sync up mpi_abi.h from upstream - mpi-forum/mpi-abi-stubs#39
Sync up mpi_abi.h from upstream - mpi-forum/mpi-abi-stubs#39
Sync up mpi_abi.h from upstream - mpi-forum/mpi-abi-stubs#39
|
@jeffhammond I think this one is also ready for merge. |
|
Does this remove all f2c/c2f? |
No, not at all! Should it?? |
|
@jeffhammond I brought your commit from #48 to update this PR. Now the mpi4py build test pass, although with a branch other than master. If everything is good with this PR from your side, please approve. |
Sync up mpi_abi.h from upstream - mpi-forum/mpi-abi-stubs#39
No description provided.