Fix most combine tests #5
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After this, the table here should be amended to say that |
|
Closing this in favor of a new branch that targets up-to-date commits on the v3 branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes almost all of the combine tests. There are a couple of notable test cases that fail as of now but these failures seem, based on my investigation so far, to somehow be related to the cases in which
coo_mapis provided toMultiZarrToZarr. In these cases, datetimes are not properly being parsed and, instead, floats are what gets decoded.Depends on:
zarr-developers/zarr-python#2533
fsspec/filesystem_spec#1755