Adding subtitle support via workaround#1038
Draft
akazukin5151 wants to merge 2 commits intomps-youtube:developfrom
Draft
Adding subtitle support via workaround#1038akazukin5151 wants to merge 2 commits intomps-youtube:developfrom
akazukin5151 wants to merge 2 commits intomps-youtube:developfrom
Conversation
Member
|
If just passing the video url is enough to have it display subtitles, i guess either the way the video url is resolved and passed to the MPV player class or some flag we're setting that is hindering them from being shown correctly. This would definitely be something that is best off being a part of the core video watching flow, as the extra functionality seemingly often gets overlooked, though if no one steps up and is willing to submit a PR fixing the issue in the main mpv player, then I'dd be happy to merge this. Gonna leave it for a short while and see |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As noted in #331 and #964, there are no subtitles when opening videos with mpv through mpsyt. Since
mpv [link]does show subtitles, the problem is likely in how mpsyt calls mpv, but I'm not sure exactly where. A temporary workaround is to add a new command, similar to the 'copy link to clipboard', except that the link goes to opening mpv directly. In the video list, typingm <number>will dompv [link]and subtitles will now work.This isn't the ideal solution (it imports
os, check for whether mpv is installed is not implemented, no mplayer support), but there's hasn't been any progress on adding subtitle support, so this workaround might be useful for people at the meantime