Fix cyclic import and #806

[vn-ki]

Fix the import problem mentioned in this comment in #799 and fix #806.

[vn-ki]

@ids1024 Probably not the best place to ask this, but in this code snippet, why is there a screen.reset_terminal()? In my machine this line messes up the whole color palette of the terminal (tset -c does it too). The code works (at least, on my machine) perfectly without that line.

https://github.com/mps-youtube/mps-youtube/blob/18fa860f7517099634c453a5b4be3cf15b268e93/mps_youtube/player.py#L77-L83

[ids1024]

Probably not the best place to ask this, but in this code snippet, why is there a screen.reset_terminal()?

I think the concern is that the mode of the terminal could be messed up if playing is just terminated; the code is probably there because of an actual issue with that happening.

Perhaps there's a better solution, but I'm not too familiar with stty, etc.

[ids1024]

I don't really like moving lastfm code out of lastfm.py. Another solution to cyclic imports like this is to move the import into the function that needs it, though that's ugly here since several functions in player.py use it.

Ideally, those calls in player.py would be replaced with some generic hook, that plugins like a lastfm plugin could use.

[vn-ki]

I think player shouldn't import anycommand. That's why I did this. What do you propose we do?

[ids1024]

For now, perhaps the if g.scrobble: code that is repeated could be replaced with a method call, BasePlayer.start_playing_hook, or something like that. Then call import lastfm in that function, to deal with the cyclic import.

In the future, this would in theory be replaced with the plugin API, so plugins can register hooks to be called there...