Merged
Conversation
alex-tee
force-pushed
the
cmake_install_flag
branch
from
757a3e7 to
73b810e
Compare
mpusz
requested changes
Sep 24, 2025
Owner
mpusz
left a comment
mpusz
left a comment
There was a problem hiding this comment.
Can you also add this option to: https://mpusz.github.io/mp-units/latest/getting_started/installation_and_usage/#cmake-options?
Maybe, you could also describe your workflow in the "Alternative installation scenarios" of this documentation file?
Implements mpusz#721.
alex-tee
force-pushed
the
cmake_install_flag
branch
from
73b810e to
1688d27
Compare
Contributor
Author
|
Just re-pushed with the requested changes. Please check. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #721.