Replace MP_UNITS_CONSTEVAL with constexpr in unit operations#725
Closed
rothmichaels wants to merge 1 commit intompusz:masterfrom
Closed
Replace MP_UNITS_CONSTEVAL with constexpr in unit operations#725rothmichaels wants to merge 1 commit intompusz:masterfrom
rothmichaels wants to merge 1 commit intompusz:masterfrom
Conversation
Changes MP_UNITS_CONSTEVAL to constexpr for unit multiplication, division, and `inverse` operations in unit.h. This was discovered with feedback on PR mpusz#644 to use `inverse`. Specifically fixes compilation error with clang (and likely other compilers?) where consteval functions cannot be called in non-constant contexts, such as: ```c++ m_frequency = inverse<si::hertz>(period); ``` Added runtime tests for `inverse()` function covering time-to-frequency conversion, runtime parameters, and unit conversion.
Contributor
Author
|
I have a better idea. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes MP_UNITS_CONSTEVAL to constexpr for unit multiplication, division, and
inverseoperations in unit.h. This was discovered with feedback on PR #644 to useinverse.Specifically fixes compilation error with clang (and likely other compilers?) where consteval functions cannot be called in non-constant contexts, such as:
Added runtime tests for
inverse()function covering time-to-frequency conversion, runtime parameters, and unit conversion.