input: apply scale to list subcommands, not the list itself #17111
+44
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, scalable commands are treated as nonscalable when they are a subcommand of a list command. This commit writes scale to scalable subcommands and individually multiplies nonscalable subcommands.
Dudemanguy
reviewed
Jan 11, 2026
| sub->scale_units = 1; | ||
| if (cmd_multiplier > 1) { | ||
| for (int i = 0; i < cmd_multiplier - 1; i++) | ||
| sub->queue_next = mp_cmd_clone(sub); |
Member
There was a problem hiding this comment.
This mp_cmd_clone seems to leak if you spam enough events with a high enough scale. I had to set sway's scroll_factor to 10 and flick the mouse wheel around to hit it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, scalable commands are treated as nonscalable when they are a subcommand of a list command. This commit writes scale to scalable subcommands and individually multiplies nonscalable subcommands.