player/command: add prepend and insert-prev flags to loadfile/loadlist #17250
+43
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No need to have a switch here. It's not like the enum order should be changed willy-nilly (although the next commit is going to do that).
Contributor
|
There is no reason to add these when they can already be achieved with the index argument set to 0 ( |
Member
Author
|
Shorthands. Of course you can already achieve these (and others) if you use insert-at. |
Dudemanguy
force-pushed
the
loadfile-flags2
branch
from
8b7d71c to
4c83aa3
Compare
Contributor
|
These "shorthands" only add interface complexity that led to #16837. I think it is better to document the |
Member
Author
|
|
Contributor
|
I still think mention in documentation is enough. We should not add less generic interfaces when generic ones are available. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.