Skip to content

wayland: move info_done variable to vo_wayland#17284

Merged
Dudemanguy merged 1 commit intompv-player:masterfrom
llyyr:fix-wayland-use-after-free
Jan 18, 2026
Merged

wayland: move info_done variable to vo_wayland#17284
Dudemanguy merged 1 commit intompv-player:masterfrom
llyyr:fix-wayland-use-after-free

Conversation

@llyyr
Copy link
Contributor

@llyyr llyyr commented Jan 18, 2026

vo_wayland_preferred_description_info is destroyed after info_done, so obviously we can't store it here. This causes a use-after-free. Embarrassing mistake

Fixes: 7a7d871

vo_wayland_preferred_description_info is destroyed after info_done, so
obviously we can't store it here. This causes a use-after-free.
Embarrassing mistake

Fixes: 7a7d871
Copy link
Member

@Dudemanguy Dudemanguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed that too. LGTM

@Dudemanguy Dudemanguy merged commit b7e8fe9 into mpv-player:master Jan 18, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants