vo: wake up core when VO requests redraw#17293
Merged
kasper93 merged 1 commit intompv-player:masterfrom Jan 20, 2026
Merged
Conversation
a74a324 returned responsibility of video redraw back to playloop. The playloop is only run if something wakes up the core. However, the logic for VO requested redraw only wakes up the core when in->want_redraw is false, which is only resetted by vo_redraw, called from the core. This creates a situation where it can never wake up the core, so redrawing never happens even when VO requests it. efc44d0 caused the issue to surface because it also throttles VO requested redraws, and in some cases results in the above behavior. Fix this by always waking up core when the VO requests redraw.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a74a324 returned responsibility of video redraw back to playloop. The playloop is only run if something wakes up the core.
However, the logic for VO requested redraw only wakes up the core when in->want_redraw is false, which is only resetted by vo_redraw, called from the core. This creates a situation where it can never wake up the core, so redrawing never happens even when VO requests it.
efc44d0 caused the issue to surface because it also throttles VO requested redraws, and in some cases results in the above behavior.
Fix this by always waking up core when the VO requests redraw.
Fixes: #17292