console.lua: use the default OSD margins when OSC margins are set#17546
Closed
guidocella wants to merge 1 commit intompv-player:masterfrom
Closed
console.lua: use the default OSD margins when OSC margins are set#17546guidocella wants to merge 1 commit intompv-player:masterfrom
guidocella wants to merge 1 commit intompv-player:masterfrom
Conversation
The OSC (with mpv-player#17544) and uosc increase --osd-margin-y along with user-data/osc/margins to not overlap with OSD messages, which positions console far apart form the bottom. Fix this by using the default --osd-margin-{x,y} when OSC margins are set. Fixes mpv-player#15334 (comment)
Member
|
I don't think this is correct. osd margins are moving the console, so you shouldn't move it again, this looks like a workaround for borken math deeper inside. |
Contributor
Author
|
I'm assuming you mean #17545 is preferred. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OSC (with #17544) and uosc increase --osd-margin-y along with user-data/osc/margins to not overlap with OSD messages, which positions console far apart form the bottom.
Fix this by using the default --osd-margin-{x,y} when OSC margins are set.
Fixes #15334 (comment)
Alternative to #17545.