f_decoder_wrapper: fix decoder name/desc allocation parent#17554
Merged
kasper93 merged 1 commit intompv-player:masterfrom Mar 10, 2026
Merged
f_decoder_wrapper: fix decoder name/desc allocation parent#17554kasper93 merged 1 commit intompv-player:masterfrom
kasper93 merged 1 commit intompv-player:masterfrom
Conversation
Those strings has to be owned by mp_codec_params, not decoder wrapper priv. Our assumption is that we set those strings here once on decoder init and they will not be changes during the life time of the mp_codec_params, hence why we need to make sure they are not deallocated too soon, in case they happen to be in use. Fixes, use after free in some cases, when tracks are deselected.
kasper93
force-pushed
the
tracks-uaf-fix
branch
from
d7b5da0 to
5dc8224
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Those strings has to be owned by mp_codec_params, not decoder wrapper priv.
Fixes, use after free in some cases, when tracks are deselected.