input: add default keybindings for secondary subtitle track cycling#17718
Open
ravarnax wants to merge 1 commit intompv-player:masterfrom
Open
input: add default keybindings for secondary subtitle track cycling#17718ravarnax wants to merge 1 commit intompv-player:masterfrom
ravarnax wants to merge 1 commit intompv-player:masterfrom
Conversation
Map 'k' to 'cycle secondary-sid' and 'K' to 'cycle secondary-sid down', mirroring the existing 'j'/'J' bindings for the primary subtitle track. Fixes mpv-player#17693
kasper93
requested changes
Apr 17, 2026
| #j cycle sub # switch subtitle track | ||
| #J cycle sub down # switch subtitle track backwards | ||
| #+k cycle secondary-sid # cycle secondary subtitle track | ||
| #+K cycle secondary-sid down |
Member
There was a problem hiding this comment.
This is not correct definition of keybinds.
kasper93
added
the
priority:needs-author-feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Map 'k' to 'cycle secondary-sid' and 'K' to 'cycle secondary-sid down', mirroring the existing 'j'/'J' bindings for the primary subtitle track.
Fixes #17693