Remove negatives in front of 0 for subtitle seeking#17749
Open
amogusussy wants to merge 1 commit intompv-player:masterfrom
Open
Remove negatives in front of 0 for subtitle seeking#17749amogusussy wants to merge 1 commit intompv-player:masterfrom
amogusussy wants to merge 1 commit intompv-player:masterfrom
Conversation
Contributor
|
Commit does not fix the issue. |
|
I often see this in ffmpeg, and this is not considered a bug there. Floating point numbers have negative zero https://stackoverflow.com/questions/5095968/does-float-have-a-negative-zero-0f |
Member
Probably it doesn't, but the change still kinda make sense, why would we set |
Contributor
IEEE has signed zero for specific reasons, it doesn't mean we need to show such nonsense on user facing interfaces. For example, we don't show the exact representation of floating values, only a rounded one up to N decimal. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you seek to a subtitle delay of 0, the message has a negative in front of it, which you typically don't write in front of 0.