test: improve test coverage from 85.7% to 88.2%#2
Merged
Conversation
Add test cases for higher-order function patterns that return variables: - goroutine: goodHigherOrderReturnsVariableWithCtx, badHigherOrderReturnsVariableWithoutCtx - errgroup: goodHigherOrderReturnsVariableWithCtx, badHigherOrderReturnsVariableWithoutCtx - waitgroup: goodHigherOrderReturnsVariableWithCtx, badHigherOrderReturnsVariableWithoutCtx - goroutinederive: Higher-order and variable function patterns Add unit tests for ignore directive package: - TestAllCheckerNames - TestParseIgnoreComment - TestBuild - TestShouldIgnore - TestGetUnusedIgnores Key coverage improvements: - returnedValueSatisfiesDerive: 15.8% -> 68.4% - ReturnedValueUsesContext: 13.3% -> 73.3% - AllCheckerNames: 0% -> 100% - usesContextDeep: 85.7% -> 95.2% - checkCallResultFuncUsesContext: 68.8% -> 87.5% 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ReturnedValueUsesContextandreturnedValueSatisfiesDerive)AllCheckerNames,parseIgnoreComment, etc.)Key Coverage Improvements
returnedValueSatisfiesDeriveReturnedValueUsesContextAllCheckerNamesusesContextDeepcheckCallResultFuncUsesContextChanges
Test fixtures added
goroutine/evil.go: Higher-order variable return patternserrgroup/evil.go: Higher-order variable return patternswaitgroup/evil.go: Higher-order variable return patternsgoroutinederive/goroutinederive.go: Higher-order and variable function patternsUnit tests added
internal/directives/ignore/directive_test.go: Tests for ignore directive parsingTest plan
./test_all.shpassesgolangci-lint run ./...passes🤖 Generated with Claude Code