Skip to content

fix: revert internal tests to internal package#26

Merged
mpyw merged 1 commit intomainfrom
fix/revert-internal-tests-to-internal-package
Dec 31, 2025
Merged

fix: revert internal tests to internal package#26
mpyw merged 1 commit intomainfrom
fix/revert-internal-tests-to-internal-package

Conversation

@mpyw
Copy link
Copy Markdown
Owner

@mpyw mpyw commented Dec 31, 2025

Summary

  • Revert internal tests from external (foo_test) back to internal (foo) package
  • Delete export_test.go files that were exporting unexported functions
  • Keep t.Parallel() calls that were added

Testing unexported functions should use internal tests, not external tests with export hacks.

Test plan

  • go test ./... passes locally
  • CI passes

🤖 Generated with Claude Code

Keep t.Parallel() but revert the external test conversion for internal
packages. Testing unexported functions should use internal tests.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.25%. Comparing base (66b7333) to head (d9d415f).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #26   +/-   ##
=======================================
  Coverage   84.25%   84.25%           
=======================================
  Files          24       24           
  Lines        1842     1842           
=======================================
  Hits         1552     1552           
  Misses        173      173           
  Partials      117      117           
Flag Coverage Δ
unittests 84.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mpyw mpyw merged commit 79313a0 into main Dec 31, 2025
14 checks passed
@mpyw mpyw deleted the fix/revert-internal-tests-to-internal-package branch December 31, 2025 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant