feat(connections): let a connection be tried before it has to be saved (#364)

src/components/__tests__/IndexModal.test.tsx

@@ -223,9 +223,17 @@ describe('IndexModal Component', () => {
       }));
     });
 
-    const fieldSelect = screen.getByTestId('index-key-field-0') as HTMLSelectElement;
-    const optionValues = Array.from(fieldSelect.options).map((o) => o.value);
-    expect(optionValues).toContain('email');
+    // Waited on the options themselves, not just on the call being made. The
+    // call having been issued says nothing about its promise having resolved
+    // and the state having been committed, so reading the list straight after
+    // was a race the test lost whenever CI was loaded enough.
+    const optionsNow = () => {
+      const select = screen.getByTestId('index-key-field-0') as HTMLSelectElement;
+      return Array.from(select.options).map((o) => o.value);
+    };
+    await waitFor(() => expect(optionsNow()).toContain('email'));
+
+    const optionValues = optionsNow();
     expect(optionValues).toContain('profile.city');
     expect(optionValues[0]).toBe('_id');
   });

src/locales/de/connections.json

@@ -59,6 +59,11 @@
     "slate": "Schiefer",
     "violet": "Violett"
   },
+  "connectNow": {
+    "connected": "Verbunden",
+    "saveOffer": "Speichere diese Verbindung, damit du sie später wieder öffnen kannst.",
+    "dontSave": "Nicht speichern"
+  },
   "connectionMode": {
     "confirmDestructive": {
       "description": "Destruktive Vorgänge müssen durch Eintippen bestätigt werden",

src/locales/en/connections.json

@@ -73,6 +73,11 @@
       "label": "Read-only"
     }
   },
+  "connectNow": {
+    "connected": "Connected",
+    "dontSave": "Don't save",
+    "saveOffer": "Save this connection so you can open it again later."
+  },
   "dialogs": {
     "deleteProfile": {
       "message": "Are you sure you want to delete this connection profile?",

src/locales/zh-Hans/connections.json

@@ -59,6 +59,11 @@
     "slate": "石板灰",
     "violet": "紫罗兰色"
   },
+  "connectNow": {
+    "connected": "已连接",
+    "saveOffer": "保存此连接，以便以后再次打开。",
+    "dontSave": "不保存"
+  },
   "connectionMode": {
     "confirmDestructive": {
       "description": "破坏性操作需要输入名称确认",

src/workspace/__tests__/persistence.test.ts

@@ -4,6 +4,7 @@ import {
   toDisconnectedSnapshot,
   rebindConnection,
   toProfileSpaceId,
+  isEphemeralProfileId,
   toLiveSpaceId,
   materializeArrivingTab,
   carriedDocumentEdit,
@@ -668,3 +669,42 @@ describe('actionToOp', () => {
     expect(actionToOp(action)).toEqual({ ...expected, window_id: 'main' });
   });
 });
+
+describe('tabs on a connection that was never saved (#369 review)', () => {
+  const tab: PersistableTab = {
+    id: 'live-conn-1:users',
+    connectionId: 'live-conn-1',
+    type: 'collection',
+    db: 'app',
+    collection: 'users',
+  };
+
+  it('are not persisted, because there is no profile to reconnect them to', () => {
+    // Persisted, the id becomes `profile:ephemeral:...`, and on restart
+    // handleReconnectProfile resolves that against load_connection_profiles —
+    // which can never list it. The tab would be stuck on "profile missing".
+    const ephemeral = {
+      id: 'live-conn-1',
+      profileId: 'ephemeral:11111111-2222-3333-4444-555555555555',
+      name: 'trial',
+    };
+    expect(toPersistedTab(tab, ephemeral, undefined)).toBeNull();
+  });
+
+  it('are persisted as normal once the connection has been saved', () => {
+    const saved = { id: 'live-conn-1', profileId: 'profile-1', name: 'Prod' };
+    const persisted = toPersistedTab(tab, saved, undefined);
+    expect(persisted).not.toBeNull();
+    expect(persisted!.profileId).toBe('profile-1');
+    expect(persisted!.id).toBe('profile:profile-1:users');
+  });
+
+  it('recognises an ephemeral id only by its own prefix', () => {
+    expect(isEphemeralProfileId('ephemeral:abc')).toBe(true);
+    expect(isEphemeralProfileId('profile-1')).toBe(false);
+    expect(isEphemeralProfileId('')).toBe(false);
+    expect(isEphemeralProfileId(undefined)).toBe(false);
+    // Not a prefix match anywhere else in the string.
+    expect(isEphemeralProfileId('not-ephemeral:abc')).toBe(false);
+  });
+});

src/workspace/persistence.ts

@@ -148,6 +148,15 @@ export interface RestoredTab {
 // `toPersistedTab` returning null for it is what App.tsx's `dispatchWorkspace`
 // reads to populate `unmirroredTabIdsRef`, so no separate change is needed.
 const NON_PERSISTED_TYPES = new Set<QueryTabType>(['export', 'import', 'generate']);
+/**
+ * Marks a connection the user opened but never saved (#364). Connection ids
+ * from `connect_db` are session-scoped, so an unsaved connection still needs
+ * *some* stable identity while it is open — the app dedupes on it — but that
+ * identity is not a profile and will never be one.
+ */
+export const EPHEMERAL_PROFILE_PREFIX = 'ephemeral:';
+export const isEphemeralProfileId = (profileId: string | undefined | null): boolean =>
+  !!profileId && profileId.startsWith(EPHEMERAL_PROFILE_PREFIX);
 // These tab kinds carry no connection at all; pass their id through as-is.
 const CONNECTIONLESS_TYPES = new Set<QueryTabType>(['settings', 'quickstart', 'tasks', 'activity']);
 
@@ -201,6 +210,13 @@ export function toPersistedTab(
 ): PersistedTab | null {
   if (NON_PERSISTED_TYPES.has(tab.type)) return null;
 
+  // A connection that was never saved has no profile to come back to. Its tabs
+  // would persist as `profile:ephemeral:<uuid>`, and on restart
+  // `handleReconnectProfile` resolves that against `load_connection_profiles`,
+  // which can never list it — so the tab would sit on "profile missing"
+  // forever. Dropped at save time instead, like an export tab (#369 review).
+  if (conn && isEphemeralProfileId(conn.profileId)) return null;
+
   if (CONNECTIONLESS_TYPES.has(tab.type)) {
     return {
       id: tab.id,