feat(connections): let a connection be tried before it has to be saved (#364)

src/App.tsx

@@ -90,6 +90,7 @@ import {
 } from './workspace/workspaceStore';
 import {
   toPersistedTab,
+  isEphemeralProfileId,
   toDisconnectedSnapshot,
   rebindConnection,
   toProfileSpaceId,
@@ -1127,7 +1128,13 @@ function Workspace() {
 
   const handleQuickConnect = async (profile: ConnectionProfile): Promise<string | null> => {
     const existing = activeConnections.find(
-      (c) => c.profileId === profile.id || c.name === profile.name,
+      (c) =>
+        c.profileId === profile.id ||
+        // Matching on name is a convenience for a profile reconnecting under a
+        // new session id. An unsaved connection must not answer to it: its name
+        // is editable and can be set to this profile's, and quick-connect would
+        // then hand back a session pointing at a different server (#369 review).
+        (c.name === profile.name && !isEphemeralProfileId(c.profileId)),
     );
     if (existing) return existing.id;
     try {
@@ -1434,6 +1441,25 @@ function Workspace() {
   const connectionNameFor = (connectionId: string): string =>
     activeConnections.find((c) => c.id === connectionId)?.name || connectionId;
 
+  /**
+   * The key a connection's saved queries, default query and history live under.
+   *
+   * Normally the display name, which is what these stores have always been
+   * keyed on. An unsaved connection gets its own ephemeral id instead: its name
+   * is editable and can be a saved profile's, and sharing a namespace would
+   * mean opening a collection ran the saved profile's default query against the
+   * trial server, while the trial's own history wrote back into the saved
+   * profile's (#369 review).
+   *
+   * Its entries are orphaned when the session ends, which is the right outcome
+   * for a connection the user declined to keep.
+   */
+  const connectionQueryKeyFor = (connectionId: string): string => {
+    const conn = activeConnections.find((c) => c.id === connectionId);
+    if (!conn) return connectionId;
+    return isEphemeralProfileId(conn.profileId) ? conn.profileId! : conn.name;
+  };
+
   // Never sit on a blank canvas — if every tab is closed, bring back Quick
   // Start. Main-window-only (Phase 3 Task 4): a secondary window has no
   // quickstart concept — the spec says an emptied secondary window closes
@@ -1576,7 +1602,7 @@ function Workspace() {
       let def: QueryDef | null = (savedQuery as QueryDef | undefined) ?? null;
       if (!def) {
         try {
-          const cq = await loadCollectionQueries(connectionNameFor(connectionId), dbName, collName);
+          const cq = await loadCollectionQueries(connectionQueryKeyFor(connectionId), dbName, collName);
           def = (cq.default as QueryDef | null) ?? null;
         } catch {
           def = null;
@@ -4520,6 +4546,7 @@ function Workspace() {
               key={tab.id}
               connectionId={tab.connectionId}
               connectionName={connectionName}
+              queryStoreKey={connectionQueryKeyFor(tab.connectionId)}
               connectionUser={connectionUser}
               databaseName={tab.db}
               collectionName={tab.collection}