Add missing AsyncClient getters and setters for MqttClient properties#54
Open
alex-goodisman wants to merge 1 commit intomqttjs:masterfrom
Open
Add missing AsyncClient getters and setters for MqttClient properties#54alex-goodisman wants to merge 1 commit intomqttjs:masterfrom
alex-goodisman wants to merge 1 commit intomqttjs:masterfrom
Conversation
Author
|
The setters may be overkill, but the base mqtt client does allow modifying them in place, so this probably should present the same API. Regardless, it should at least have the missing getters. |
RangerMauve
requested changes
Jan 10, 2023
Contributor
RangerMauve
left a comment
RangerMauve
left a comment
There was a problem hiding this comment.
Mind updating the index.d.ts typings to match the new properties?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The type definitions claims that AsyncClient extends MqttClient, which implies that all of the public properties present on MqttClient can be accessed on AsyncClient. However, several of the getters and setters are missing. The full list added is:
Properties that had a getter but not setter (setter added):
connectedreconnectingProperties that had neither (both added):
disconnectingdisconnectedincomingStoreoutgoingStoreoptionsqueueQoSZeroThis will allow the AsyncClient to read and modify these values in the same manner as the base class client.