Skip to content

Conversation

@inadarei
Copy link

See: #4

@ianfixes
Copy link

I think #8 might be a better implementation of this

@NxP4Code
Copy link

@mrako , can you please process this merge request if you agree with the changes.

@inadarei
Copy link
Author

#8 is not a better fix, because as far as I can tell, it still allows modification of generally-named env vars in the global scope, for the duration of the script's execution. If some other process relies on Port or Host during that tim, you will still get issues. These var names are way too common to let them be touched in such script

@NxP4Code
Copy link

My comment is related to changes included in this pull request. It seems the file changed shows that generally-named env vars are taken care of in https://github.com/mrako/wait-for/pull/5/files

@mrako
Copy link
Owner

mrako commented Mar 16, 2021

Hello! Sorry for lagging...

Can you take a look at eficode/wait-for? It is still maintained. I will update this branch once you confirm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants