Skip to content

Commit cdc00bb

Browse files
authored
Merge pull request #175 from mrc-ide/fix_parse_durations
parse_durations fix
2 parents deb113e + 0eb619f commit cdc00bb

File tree

4 files changed

+28
-1
lines changed

4 files changed

+28
-1
lines changed

DESCRIPTION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
Package: squire
22
Type: Package
33
Title: SEIR transmission model of COVID-19
4-
Version: 0.6.10
4+
Version: 0.6.11
55
Authors@R: c(
66
person("OJ", "Watson", email = "o.watson15@imperial.ac.uk", role = c("aut", "cre")),
77
person("Patrick", "Walker", email = "patrick.walker06@imperial.ac.uk", role = c("aut")),

NEWS.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
# squire 0.6.11
2+
3+
* `parse_durations` bug fix. Handles dur_E, dur_IMild and dur_ICase correctly now
4+
15
# squire 0.6.10
26

37
* `sample_pmcmc` bug fix dor negative posterior checks incorrectly.

R/parameters.R

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -322,6 +322,9 @@ parameters_explicit_SEEIR <- function(
322322
dur_not_get_mv_die = dur_not_get_mv_die,
323323
dur_rec = dur_rec,
324324
dur_R = dur_R,
325+
dur_E = dur_E,
326+
dur_IMild = dur_IMild,
327+
dur_ICase = dur_ICase,
325328
walker_params = walker_params)
326329

327330
dur_get_ox_survive <- duration_params$dur_get_ox_survive

tests/testthat/test-run.R

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -281,3 +281,23 @@ test_that("default probs", {
281281
"prob_severe_death_no_treatment","p_dist"))
282282

283283
})
284+
285+
286+
287+
test_that("duration E, IMild, ICase, changes through parse_durations", {
288+
289+
r <- run_deterministic_SEIR_model("Iran", time_period = 2, dur_E = 1, day_return = TRUE)
290+
r2 <- run_deterministic_SEIR_model("Iran", time_period = 2, dur_E = 10, day_return = TRUE)
291+
expect_true(r$parameters$gamma_E != r2$parameters$gamma_E)
292+
293+
294+
r <- run_deterministic_SEIR_model("Iran", time_period = 2, dur_IMild = 1, day_return = TRUE)
295+
r2 <- run_deterministic_SEIR_model("Iran", time_period = 2, dur_IMild = 10, day_return = TRUE)
296+
expect_true(r$parameters$gamma_IMild != r2$parameters$gamma_IMild)
297+
298+
299+
r <- run_deterministic_SEIR_model("Iran", time_period = 2, dur_ICase = 1, day_return = TRUE)
300+
r2 <- run_deterministic_SEIR_model("Iran", time_period = 2, dur_ICase = 10, day_return = TRUE)
301+
expect_true(r$parameters$gamma_ICase != r2$parameters$gamma_ICase)
302+
303+
})

0 commit comments

Comments
 (0)