Skip to content

Conversation

@mrcjkb
Copy link
Owner

@mrcjkb mrcjkb commented Jan 7, 2026

Closes #863.

Removing .vscode/settings.json support in favour of the codesettings.nvim plugin.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2026

Review Checklist

Does this PR follow the Contribution Guidelines? Following is a partial checklist:

Proper conventional commit scoping:

  • For example, fix(lsp): some lsp-related bugfix

  • Pull request title has the appropriate conventional commit prefix.

If applicable:

  • Tested
    • Tests have been added.
    • Tested manually (Steps to reproduce in PR description).
  • Updated documentation.

@mrcjkb mrcjkb marked this pull request as draft January 7, 2026 10:14
@mrcjkb mrcjkb force-pushed the mj/push-vnttwlnrzrkz branch from ad1dfaf to 6b4da55 Compare January 7, 2026 14:44
@mrcjkb mrcjkb marked this pull request as ready for review January 7, 2026 14:47
@mrcjkb mrcjkb force-pushed the mj/push-vnttwlnrzrkz branch from 6b4da55 to 581d7a4 Compare January 7, 2026 14:47
@mrcjkb mrcjkb force-pushed the mj/push-vnttwlnrzrkz branch from 581d7a4 to 0842633 Compare January 7, 2026 15:03
@mrjones2014
Copy link

mrjones2014 commented Jan 7, 2026

I tested codesettings.nvim against release v7.0.9 and the global hook with before_init now works, no special config for rustaceanvim needed

vim.g.rustaceanvim = {
  server = {
    -- rely on codesettings.nvim to load workspace settings
    load_vscode_settings = false,
    ---@type lsp.rust_analyzer
    default_settings = {
      -- your global settings go here
    },
  },
}

Updated my docs here: mrjones2014/codesettings.nvim#99

@mrcjkb
Copy link
Owner Author

mrcjkb commented Jan 7, 2026

I'll leave this PR open for a while, as the nvim 0.12 release is nearing. Then I can put 2 breaking changes in one major version bump when I drop nvim 0.11 support.

@mrcjkb mrcjkb changed the title feat(lsp)!: remove .vscode/settings.json support feat(lsp)!: remove .vscode/settings.json support in favour of codesettings.nvim Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

remove .vscode/settings.json loading logic in favour of codesettings.nvim

3 participants