Add scssphp 2.x compatibility while maintaining backward compatibility #717
+31
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use CompilationResult::getIncludedFiles() for scssphp 2.x - Fall back to Compiler::getParsedFiles() for scssphp 1.x - Runtime detection via method_exists() Fixes compatibility with PHP 8.5+ which requires scssphp 2.x Related: mrclay#715
- Update .semver to 4.0.2 - Add changelog entry for scssphp 2.x compatibility - Update composer.json to allow scssphp ^1.12|^2.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds compatibility with scssphp 2.x while maintaining backward compatibility with scssphp 1.x.
Problem
The current implementation uses
Compiler::getParsedFiles()which was removed in scssphp 2.0. This causes a fatal error when using mrclay/minify with scssphp 2.x:Since scssphp 2.x is required for PHP 8.5 compatibility, this fix is necessary for future PHP versions.
Changes
Minify_ScssCssSource::compile()to useCompilationResult::getIncludedFiles()for scssphp 2.xCompiler::getParsedFiles()for scssphp 1.x (runtime detection viamethod_exists())filemtime()composer.jsonto allowscssphp/scssphp: ^1.12|^2.0Related Issues
Fixes #715